Standardize mpi-serial MPI function prototypes with MPICH #37
Conversation
The mpi-serial library supports most common MPI calls, but some function prototypes differ from their MPICH counterparts. This update ensures consistency by aligning function declarations with those in MPICH 4.3.0 (see src/include/mpi_proto.h).
|
References: Tests: |
jedwards4b
left a comment
jedwards4b
left a comment
There was a problem hiding this comment.
Thank you for this contribution.
jayeshkrishna
left a comment
jayeshkrishna
left a comment
There was a problem hiding this comment.
Can you also include a summary of the changes in the PR (const correctness, arrays vs pointers etc)?
|
@dqwu : Either update the PR desc (PR commit message) or the change commit message to list out the changes in the PR (you can add the list to the current PR desc for ex). Also make the req buf type change in a separate commit |
Updated buf to void* in struct Req for better generality in handling user buffers. Added an explicit cast in MPI_Isend() to suppress the warning about discarded const qualifiers.
OK, I have updated the PR description. |
|
@jedwards4b, is this PR good to go? Thanks! |
This PR introduces several updates to the mpi-serial library to
improve consistency and maintainability.
Changes:
adjustments to const correctness and the use of arrays
vs. pointers.
in declarations.
updated MPI function signatures.
generality in handling user buffers.